Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add L4 DualStack Sync Latency metrics #1945

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Add L4 DualStack Sync Latency metrics #1945

merged 1 commit into from
Feb 17, 2023

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Feb 11, 2023 •
edited
Loading

Add a new metric, similar to L4 ILB, NetLB Latency, which will report latencies if L4 DualStack enabled, with ipfamilies as a new label

Should be merged after #1937

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2023
@panslava panslava force-pushed the ilb-dualstack-sync-latency branch from 8041baf to aeadde1 Compare February 11, 2023 15:21
@panslava
Copy link
Contributor Author

/assign cezarygerard

@panslava panslava force-pushed the ilb-dualstack-sync-latency branch from aeadde1 to c273f09 Compare February 15, 2023 14:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
@panslava panslava changed the title Add L4 ILB DualStack Sync Latency metrics Add L4 DualStack Sync Latency metrics Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2023
cezarygerard
cezarygerard reviewed Feb 16, 2023
View reviewed changes
pkg/l4lb/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/l4lb/metrics/metrics.go Outdated Show resolved Hide resolved
@panslava panslava force-pushed the ilb-dualstack-sync-latency branch from c273f09 to 76c5640 Compare February 16, 2023 23:12
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2023
@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b696408 into kubernetes:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezarygerard cezarygerard cezarygerard left review comments

@aojea aojea Awaiting requested review from aojea

@prameshj prameshj Awaiting requested review from prameshj

Assignees

@cezarygerard cezarygerard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panslava @cezarygerard @k8s-ci-robot